[PATCH] fixup! bisect--helper: `bisect_next_check` & bisect_voc shell function in C
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 10, 2017, 14:20 UTC
- Message-ID
- <a1b9143bb29a8a5979dd733ed20161e6769b2b83.1486736391.git.johannes.schindelin@gmx.de>
It is curious that only MacOSX builds trigger an error about this, both GCC and Clang, but not Linux GCC nor Clang (see https://travis-ci.org/git/git/jobs/200182819#L1152 for details):
builtin/bisect--helper.c:299:6: error: variable 'good_syn' is used
uninitialized whenever 'if' condition is true
[-Werror,-Wsometimes-uninitialized]
if (missing_good && !missing_bad && current_term &&
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
builtin/bisect--helper.c:350:7: note: uninitialized use occurs here
if (!good_syn)
^~~~~~~~If you "re-roll" (or, as pointed out at the Contributors' Summit, better put: if you send another iteration of the patch series), please squash this fix in.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- Based-On: pu at https://github.com/dscho/git Fetch-Base-Via: git fetch https://github.com/dscho/git pu Published-As: https://github.com/dscho/git/releases/tag/bisect--helper-fixup-v1 Fetch-It-Via: git fetch https://github.com/dscho/git bisect--helper-fixup-v1
builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 8cd6527bd1..614a85ffb5 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -280,7 +280,7 @@ static int bisect_next_check(const struct bisect_terms *terms, int missing_good = 1, missing_bad = 1, retval = 0; char *bad_ref = xstrfmt("refs/bisect/%s", terms->term_bad); char *good_glob = xstrfmt("%s-*", terms->term_good); - char *bad_syn, *good_syn; + char *bad_syn = NULL, *good_syn = NULL; if (ref_exists(bad_ref)) missing_bad = 0; base-commit: 6fa4b393c01a84c9adf2e2435fba6de13227eabf
-- 2.11.1.windows.1