Re: [PATCH] push: comment on a funny unbalanced option help

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 3, 2018, 15:29 UTC
Message-ID: <xmqqa7q31naq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <ea253620-ed28-54a4-0e52-16cbf4ec8451@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 19 quoted lines

> Am 02.08.2018 um 22:01 schrieb Junio C Hamano:
>> 
>> Straying sideways into a tangent, but do we know if any locale wants
>> to use something other than "<>" as an enclosing braket around a
>> placeholder?
>
> Bulgarian seems to use capitals instead; here are some examples found
> with git grep -A1 'msgid "<' po/:
>
> po/bg.po:msgid "<remote>"
> po/bg.po-msgstr "ОТДАЛЕЧЕНО_ХРАНИЛИЩЕ"
> ...
>> 
>> Perhaps we should do _("<%s>") here?  That way, the result would
>> hopefully be made consistent with
>> 
>> 	N_("<refspec>[:<expect>]")	with LIT-ARG-HELP
>> 
>> which allows translator to use the bracket of the locale's choice.

I did not consider locales that do not use any kind of bracket, but I guess _("<%s>") would work for them, too, in this context. When the locale's convention is to upcase, for example, the arg-help text that is not marked with PARSE_OPT_LITERAL_ARGHELP would be upcased, and _("<%s>") in the usage_argh() can be translated to "%s", which passes the translated (i.e. upcased) arg-help text through.