Re: [PATCH] push: comment on a funny unbalanced option help

From: René Scharfe <l.s.r@web.de>
Date: Aug 2, 2018, 22:38 UTC
Message-ID: <ea253620-ed28-54a4-0e52-16cbf4ec8451@web.de>
In-Reply-To: <xmqqzhy4zgfv.fsf@gitster-ct.c.googlers.com>

Am 02.08.2018 um 22:01 schrieb Junio C Hamano:

Show 13 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
>> Am 02.08.2018 um 18:54 schrieb Jeff King:
>>> PS I actually would have made the rule simply "does it begin with a
>>>      '<'", which seems simpler still. If people accidentally write "<foo",
>>>      forgetting to close their brackets, that is a bug under both the
>>>      old and new behavior (just with slightly different outcomes).
>>
>> Good point.
> 
> Straying sideways into a tangent, but do we know if any locale wants
> to use something other than "<>" as an enclosing braket around a
> placeholder?

Bulgarian seems to use capitals instead; here are some examples found with git grep -A1 'msgid "<' po/:

po/bg.po:msgid "<remote>" po/bg.po-msgstr "ОТДАЛЕЧЕНО_ХРАНИЛИЩЕ" -- po/bg.po:msgid "<branch>" po/bg.po-msgstr "КЛОН" -- po/bg.po:msgid "<subdirectory>/" po/bg.po-msgstr "ПОДДИРЕКТОРИЯ/" -- po/bg.po:msgid "<n>[,<base>]" po/bg.po-msgstr "БРОЙ[,БАЗА]"

Show 17 quoted lines

>  This arg-help text, for example,
> 
> 	N_("refspec")			without LIT-ARG-HELP
> 
> would be irritating for such a locale's translator, who cannot
> defeat the "<>" that is hardcoded and not inside _()
> 
> 	s = literal ? "%s" : "<%s>";
>                          
> that appear in parse-options.c::usage_argh().
> 
> Perhaps we should do _("<%s>") here?  That way, the result would
> hopefully be made consistent with
> 
> 	N_("<refspec>[:<expect>]")	with LIT-ARG-HELP
> 
> which allows translator to use the bracket of the locale's choice.

@Alexander: Would that help you?

René