git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/1] [Outreachy] commit: display advice hints when commit fails

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 21, 2019, 23:54 UTC
Message-ID
<xmqqa77l6xpo.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CACg5j249Ttouiua7iSfMGi7ZaKOanb0TCbMFmEjVtzKsPur4PA@mail.gmail.com>
Heba Waly <heba.waly@gmail.com> writes:
Show 9 quoted lines
>> Any contributor working on this topic should be competent enough to
>> realize/notice it once it is pointed out---even though lack of
>> proof-reading before sending may cause such a mistake by
>> carelessness.
>
> I have no reason not to believe that this is crossing the line.
> No matter how much a reviewer disagrees with the proposed changes, I'd
> appreciate
> keeping a mutually respectful discussion during the review process.

I do not see any lack of respect in saying that I believed you are competent enough that a short "Huh?" answer was sufficient.

Previous: Heba WalyNext: Heba Waly
Message 26 of 27 in “[Outreachy] commit: display advice hints when commit fails”
  1. 0/1 [Outreachy] commit: display advice hints when commit failsHeba Waly via GitGitGadget, Dec 17, 2019
  2. 1/1 commit: display advice hints when commit failsHeba Waly via GitGitGadget, Dec 17, 2019
  3. Junio C HamanoDec 17, 2019
  4. Emily ShafferDec 17, 2019
  5. Heba WalyDec 19, 2019
  6. Jonathan TanDec 18, 2019
  7. Junio C HamanoDec 18, 2019
  8. Heba WalyDec 19, 2019
  9. 0/1 [Outreachy] commit: display advice hints when commit failsHeba Waly via GitGitGadget, Dec 19, 2019
  10. 1/1 commit: display advice hints when commit failsHeba Waly via GitGitGadget, Dec 19, 2019
  11. Junio C HamanoDec 19, 2019
  12. Junio C HamanoDec 19, 2019
  13. Eric SunshineDec 19, 2019
  14. Junio C HamanoDec 19, 2019
  15. Emily ShafferDec 20, 2019
  16. Junio C HamanoDec 20, 2019
  17. Emily ShafferDec 20, 2019
  18. Jonathan TanDec 31, 2019
  19. Junio C HamanoDec 31, 2019
  20. Jonathan TanJan 2, 2020
  21. Junio C HamanoDec 19, 2019
  22. Emily ShafferDec 19, 2019
  23. Junio C HamanoDec 19, 2019
  24. Junio C HamanoDec 19, 2019
  25. Heba WalyDec 21, 2019
  26. Junio C HamanoDec 21, 2019
  27. Heba WalyDec 21, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.