Re: [PATCH v2 1/1] commit: display advice hints when commit fails

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 19, 2019, 19:47 UTC
Message-ID: <CAPig+cQZBXOZeYDJRH+9YLobTOP1_UndV_Snk+S0_LL1=h-aag@mail.gmail.com>
In-Reply-To: <xmqqbls4aznl.fsf@gitster-ct.c.googlers.com>

On Thu, Dec 19, 2019 at 2:22 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 5 quoted lines

> In any case, here is what I tentatively have in my tree (with heavy
> rewrite to the proposed log message).
>
> +test_expect_success 'commit without staging files fails and displays hints' '
> +       echo "initial" >>file &&

The use of '>>' here rather than '>' feels wrong, especially when "initial" is used for both the file body and the commit message, causing a reader of the test to wonder if this test somehow depends upon earlier tests.

Show 6 quoted lines

> +       git add file &&
> +       git commit -m initial &&
> +       echo "changes" >>file &&
> +       test_must_fail git commit -m update >actual &&
> +       test_i18ngrep "no changes added to commit (use \"git add\" and/or \"git commit -a\")" actual
> +'