Re: [PATCH v2 0/1] [Outreachy] commit: display advice hints when commit fails

From: Emily Shaffer <emilyshaffer@google.com>
Date: Dec 19, 2019, 18:54 UTC
Message-ID: <20191219185427.GA227872@google.com>
In-Reply-To: <xmqqlfr8b28v.fsf@gitster-ct.c.googlers.com>

On Thu, Dec 19, 2019 at 10:26:40AM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> "Heba Waly via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> >      @@ -19,16 +19,16 @@
> >             #   (use "git add <file>..." to update what will be committed)
> >             #   (use "git checkout -- <file>..." to discard changes in working directory)
> >             #
> >      -      #   modified:   ../builtin/commit.c
> >      +      #   modified:   /builtin/commit.c
> 
> Really?

It's hard to know what this cryptic comment means.. :)

This was a recommended change: https://lore.kernel.org/git/20191218031338.203382-1-jonathantanmy@google.com

Since other changes were being made at the same time, I personally don't mind a little nit fix in the commit message.

Or, do you mean that "now it looks like the file is at the filesystem root, which is wrong"? It is indeed wrong now when it wasn't before. But I, for one, can't tell what you mean by just the one word.

 - Emily