Re: [PATCH v2 0/1] [Outreachy] commit: display advice hints when commit fails

From: Heba Waly <heba.waly@gmail.com>
Date: Dec 21, 2019, 04:37 UTC
Message-ID: <CACg5j249Ttouiua7iSfMGi7ZaKOanb0TCbMFmEjVtzKsPur4PA@mail.gmail.com>
In-Reply-To: <xmqq36dgayma.fsf@gitster-ct.c.googlers.com>

On Fri, Dec 20, 2019 at 8:45 AM Junio C Hamano <gitster@pobox.com> wrote:

>
> That is exactly the point.  I am not in the business of spoon
> feeding answers.

Why would pointing out a typo clearly to the author be considered as spoon feeding answers? Rather than simply reviewing and pointing out mistakes in a clear and a respectful way?

> I want my contributors to *think*.

Nobody is against *thinking*, and I'm sure an author who found an issue and implemented a fix had his/her share of thinking to get the job done. So I hope a typo is not standing in the way of acknowledging the author's effort.

> Any contributor working on this topic should be competent enough to
> realize/notice it once it is pointed out---even though lack of
> proof-reading before sending may cause such a mistake by
> carelessness.

I have no reason not to believe that this is crossing the line. No matter how much a reviewer disagrees with the proposed changes, I'd appreciate keeping a mutually respectful discussion during the review process.

Heba