Re: [PATCH v3 1/3] test-lib-functions: handle --add in test_config

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2020, 19:00 UTC
Message-ID: <xmqqa6u7m1bu.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cSaq4vTK7CtvxB2bd0=WTW+d=s0H2RMquyCEf+q0YVn2w@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 10 quoted lines

> Finally, as this is a one-off case, it might be simpler just to drop
> this patch altogether and open-code the cleanup in the test itself in
> patch [2/3] rather than bothering with test_config() in that
> particular case. For example:
>
>     test_when_finished "test_unconfig -C two remote.one.push" &&
>     git config -C two --add remote.one.push : &&
>     test_must_fail git -C two push one &&
>     git config -C two --add remote.one.push ^refs/heads/master &&
>     git -C two push one

That would be my preference, too. Thanks for carefully and patiently reviewing.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.