git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] negative-refspec: improve comment on query_matches_negative_refspec

From
Nipunn Koorapati via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 19, 2020, 21:58 UTC
Message-ID
<8da8d9cd1c5230aa3a62f1d339c5006d33630edd.1608415117.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.820.v2.git.1608415117.gitgitgadget@gmail.com>
From: Nipunn Koorapati <nipunn@dropbox.com>

Comment did not adequately explain how the two loops work together to achieve the goal of querying for matching of any negative refspec.

Signed-off-by: Nipunn Koorapati <nipunn@dropbox.com>
---
 remote.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/remote.c b/remote.c
index cbb3113b105..6cdaa8da75a 100644
--- a/remote.c
+++ b/remote.c
@@ -736,6 +736,12 @@ static int query_matches_negative_refspec(struct refspec *rs, struct refspec_ite
 	 * item uses the destination. To handle this, we apply pattern
 	 * refspecs in reverse to figure out if the query source matches any
 	 * of the negative refspecs.
+	 *
+	 * The first loop finds and expands all positive refspecs
+	 * matched by the queried ref.
+	 *
+	 * The second loop checks if any of the results of the first loop
+	 * match any negative refspec.
 	 */
 	for (i = 0; i < rs->nr; i++) {
 		struct refspec_item *refspec = &rs->items[i];
-- 
gitgitgadget
Previous: Eric SunshineNext: Nipunn Koorapati via GitGitGadget
Message 7 of 33 in “negative-refspec: fix segfault on : refspec”
  1. negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 19, 2020
  2. Junio C HamanoDec 19, 2020
  3. Jacob KellerFeb 19, 2021
  4. 0/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 19, 2020
  5. 1/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 19, 2020
  6. Eric SunshineDec 20, 2020
  7. 2/2 negative-refspec: improve comment on query_matches_negative_refspecNipunn Koorapati via GitGitGadget, Dec 19, 2020
  8. 0/3 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 21, 2020
  9. 3/3 negative-refspec: improve comment on query_matches_negative_refspecNipunn Koorapati via GitGitGadget, Dec 21, 2020
  10. 2/3 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 21, 2020
  11. Eric SunshineDec 21, 2020
  12. 1/3 test-lib-functions: handle --add in test_configNipunn Koorapati via GitGitGadget, Dec 21, 2020
  13. Eric SunshineDec 21, 2020
  14. Junio C HamanoDec 21, 2020
  15. Eric SunshineDec 21, 2020
  16. Nipunn KoorapatiDec 22, 2020
  17. Eric SunshineDec 22, 2020
  18. Nipunn KoorapatiDec 22, 2020
  19. Eric SunshineDec 22, 2020
  20. 0/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  21. 2/2 negative-refspec: improve comment on query_matches_negative_refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  22. 1/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  23. Junio C HamanoDec 22, 2020
  24. Junio C HamanoDec 22, 2020
  25. 0/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  26. 2/2 negative-refspec: improve comment on query_matches_negative_refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  27. 1/2 negative-refspec: fix segfault on : refspecNipunn Koorapati via GitGitGadget, Dec 22, 2020
  28. Jacob KellerFeb 19, 2021
  29. Junio C HamanoDec 22, 2020
  30. Nipunn KoorapatiDec 23, 2020
  31. Junio C HamanoDec 24, 2020
  32. Nipunn KoorapatiJan 11, 2021
  33. Junio C HamanoJan 12, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.