Re: [PATCH v5 8/9] dir: update stale description of treat_directory()

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2021, 19:44 UTC
Message-ID: <xmqqa6ot6t7m.fsf@gitster.g>
In-Reply-To: <bac325b9-8370-601b-a348-a7270df8b824@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 20 quoted lines

> On 5/12/2021 1:28 PM, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>
>> 
>> The documentation comment for treat_directory() was originally written
>> in 095952 (Teach directory traversal about subprojects, 2007-04-11)
>> which was before the 'struct dir_struct' split its bitfield of named
>> options into a 'flags' enum in 7c4c97c0 (Turn the flags in struct
>> dir_struct into a single variable, 2009-02-16). When those flags
>> changed, the comment became stale, since members like
>> 'show_other_directories' transitioned into flags like
>> DIR_SHOW_OTHER_DIRECTORIES.
>> 
>> Update the comments for treat_directory() to use these flag names rather
>> than the old member names.
>> 
>> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
>> Reviewed-by: Elijah Newren <newren@gmail.com>
>
> I think you want the "Reviewed-by" before the "Signed-off-by",
> followed by your own sign-off.

Grabbing somebody else's signed-off patch, and forwarding it (with or without tweaks and enhancements) with your own sign-off would be a sufficient sign that you've inspected the patch deeply enough to be confident that it is worth forwarding. So I think you can even lose the reviewed-by.

But as long as you are relaying somebody else's patch, DCO asks you to sign it off yourself.

Thanks.