Re: [PATCH v2 1/8] t7300: add testcase showing unnecessary traversal into ignored directory

From: Elijah Newren <newren@gmail.com>
Date: May 8, 2021, 17:41 UTC
Message-ID: <CABPp-BG7Rp7QtSSDCwjmOC=SJZ7Uuw8Uddtu+VHbiFaRQAUJKQ@mail.gmail.com>
In-Reply-To: <xmqq8s4pv87t.fsf@gitster.g>

On Sat, May 8, 2021 at 3:19 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +             # alpine-linux-musl fails to "rm -rf" a directory with such
> > +             # a deeply nested hierarchy.  Help it out by deleting the
> > +             # leading directories ourselves.  Super slow, but, what else
> > +             # can we do?  Without this, we will hit a
> > +             #     error: Tests passed but test cleanup failed; aborting
> > +             # so do this ugly manual cleanup...
> > +             while test ! -f directory-random-file.txt; do
> > +                     name=$(ls -d directory*) &&
> > +                     mv $name/* . &&
> > +                     rmdir $name
> > +             done
>
> Another thing: this not being a test_when_finished handler means it
> would not help after a test failure.

test failures are irrelevant here; this code is here to help test_done's directory cleanup, which only fires when all tests pass.

But if I restructure the series, this whole section of code disappears. I'll do that...