Re: [PATCH v5 8/9] dir: update stale description of treat_directory()
- From
Derrick Stolee <stolee@gmail.com>
- Date
- May 17, 2021, 17:20 UTC
- Message-ID
- <bac325b9-8370-601b-a348-a7270df8b824@gmail.com>
- In-Reply-To
- <179f992edc9254803252ae10e5d692f3755a40f3.1620840502.git.gitgitgadget@gmail.com>
On 5/12/2021 1:28 PM, Derrick Stolee via GitGitGadget wrote:
Show 16 quoted lines
> From: Derrick Stolee <stolee@gmail.com> > > The documentation comment for treat_directory() was originally written > in 095952 (Teach directory traversal about subprojects, 2007-04-11) > which was before the 'struct dir_struct' split its bitfield of named > options into a 'flags' enum in 7c4c97c0 (Turn the flags in struct > dir_struct into a single variable, 2009-02-16). When those flags > changed, the comment became stale, since members like > 'show_other_directories' transitioned into flags like > DIR_SHOW_OTHER_DIRECTORIES. > > Update the comments for treat_directory() to use these flag names rather > than the old member names. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > Reviewed-by: Elijah Newren <newren@gmail.com>
I think you want the "Reviewed-by" before the "Signed-off-by", followed by your own sign-off.
Thanks, -Stolee