From: Junio C Hamano Date: Mon, 17 May 2021 19:44:29 GMT Subject: Re: [PATCH v5 8/9] dir: update stale description of treat_directory() Message-ID: In-Reply-To: Derrick Stolee writes: > On 5/12/2021 1:28 PM, Derrick Stolee via GitGitGadget wrote: >> From: Derrick Stolee >> >> The documentation comment for treat_directory() was originally written >> in 095952 (Teach directory traversal about subprojects, 2007-04-11) >> which was before the 'struct dir_struct' split its bitfield of named >> options into a 'flags' enum in 7c4c97c0 (Turn the flags in struct >> dir_struct into a single variable, 2009-02-16). When those flags >> changed, the comment became stale, since members like >> 'show_other_directories' transitioned into flags like >> DIR_SHOW_OTHER_DIRECTORIES. >> >> Update the comments for treat_directory() to use these flag names rather >> than the old member names. >> >> Signed-off-by: Derrick Stolee >> Reviewed-by: Elijah Newren > > I think you want the "Reviewed-by" before the "Signed-off-by", > followed by your own sign-off. Grabbing somebody else's signed-off patch, and forwarding it (with or without tweaks and enhancements) with your own sign-off would be a sufficient sign that you've inspected the patch deeply enough to be confident that it is worth forwarding. So I think you can even lose the reviewed-by. But as long as you are relaying somebody else's patch, DCO asks you to sign it off yourself. Thanks.