Re: [PATCH 2/4] object-file: refactor corrupt object diagnosis

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 30, 2022, 23:42 UTC
Message-ID: <xmqqa648uhz2.fsf@gitster.g>
In-Reply-To: <Y4fBdW4IMhVXazm4@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

> So maybe:
>
>   if (!oideq(real_oid, oid))
>
> instead? It's a little slower, but the point of this is to diagnose and
> die, so it's not exactly a hot path. :)

Very true, including the part that the original is fine because it is localized and fairly obvious. For a public function, we cannot assume any additional constraints between oid and real_oid (other than they are of the same "struct object_id *" type) like the two pointers prepared locally in the original had, and use of oideq() would be more appropriate here.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.