Re: [PATCH v3 2/4] object-file: refactor map_loose_object_1()

From: Jeff King <peff@peff.net>
Date: Dec 9, 2022, 20:27 UTC
Message-ID: <Y5OaLKmIXvbEI1bP@coredump.intra.peff.net>
In-Reply-To: <20221209181704.106534-1-jonathantanmy@google.com>

On Fri, Dec 09, 2022 at 10:17:04AM -0800, Jonathan Tan wrote:

Show 8 quoted lines

> Jeff King <peff@peff.net> writes:
> > If you take my suggestion on patch 3, then the only other caller of
> > map_loose_object_1() goes away, and we can fold it all into one
> > reasonably-named function:
> 
> Ah, that is true as of this patch, but patch 3 introduces another caller
> of this function. I tried to allude to it in the commit message, but if
> there is a clearer way to explain that, please let me know.

Yes, that's the "other caller" I was referring to. :) Hopefully it is more clear after you read my comments on v3.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.