Re: [PATCH v3 2/4] object-file: refactor map_loose_object_1()

From: Jeff King <peff@peff.net>
Date: Dec 9, 2022, 20:27 UTC
Message-ID: <Y5OaScWCzzhIumtM@coredump.intra.peff.net>
In-Reply-To: <Y5OaLKmIXvbEI1bP@coredump.intra.peff.net>

On Fri, Dec 09, 2022 at 03:27:24PM -0500, Jeff King wrote:

Show 13 quoted lines

> On Fri, Dec 09, 2022 at 10:17:04AM -0800, Jonathan Tan wrote:
> 
> > Jeff King <peff@peff.net> writes:
> > > If you take my suggestion on patch 3, then the only other caller of
> > > map_loose_object_1() goes away, and we can fold it all into one
> > > reasonably-named function:
> > 
> > Ah, that is true as of this patch, but patch 3 introduces another caller
> > of this function. I tried to allude to it in the commit message, but if
> > there is a clearer way to explain that, please let me know.
> 
> Yes, that's the "other caller" I was referring to. :) Hopefully it is
> more clear after you read my comments on v3.

Er, that should be "...comments on patch 3", of course, not "v3".

-Peff