Re: [PATCH 4/4] commit: don't lazy-fetch commits

From: Jeff King <peff@peff.net>
Date: Dec 1, 2022, 19:33 UTC
Message-ID: <Y4kBor6o+Sclifny@coredump.intra.peff.net>
In-Reply-To: <20221201191150.3605771-1-jonathantanmy@google.com>

On Thu, Dec 01, 2022 at 11:11:50AM -0800, Jonathan Tan wrote:

Show 12 quoted lines

> Jeff King <peff@peff.net> writes:
> > OK, so we know we want a commit object because we're in the
> > commit-parsing function, so we just ask to disable fetching.
> > 
> > Two devil's advocate thoughts:
> [...]
> 
> Thanks for taking a look. Let me know if you think that the commit message
> could be improved to cover these cases. Right now I think that e.g. "When
> parsing an object believed to be a commit in repo_parse_commit_internal()"
> instead of "When parsing commits" wouldn't add much value, but I might be
> missing something.

I think your commit message is OK as-is. I was mostly just laying out my thoughts in reviewing. Some of that could go into the commit message as notes, but I think it is sufficient that they're here in the list archive.

-Peff