Re: [PATCH v2 6/7] strbuf: clarify dependency

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2023, 19:26 UTC
Message-ID: <xmqqa5ylqkri.fsf@gitster.g>
In-Reply-To: <20230503185031.1810078-6-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

> refs.h was once needed but is no longer so as of 6bab74e7fb8 ("strbuf:
> move strbuf_branchname to sha1_name.c", 2010-11-06). strbuf.h was
> included thru refs.h, so removing refs.h requires strbuf.h to be added
> back.

OK.  Will queue.  Thanks.

Show 19 quoted lines

>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> ---
>  strbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/strbuf.c b/strbuf.c
> index 178d75f250..d5978fee4e 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -3,7 +3,7 @@
>  #include "environment.h"
>  #include "gettext.h"
>  #include "hex.h"
> -#include "refs.h"
> +#include "strbuf.h"
>  #include "string-list.h"
>  #include "utf8.h"
>  #include "date.h"

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.