Re: [PATCH 5/6] strbuf: clarify dependency

From: Elijah Newren <newren@gmail.com>
Date: May 3, 2023, 01:56 UTC
Message-ID: <CABPp-BGLcUnqZvYNG_5pNOXSHCtryVyXoMJHdX5eXdkgYAS24Q@mail.gmail.com>
In-Reply-To: <20230502211454.1673000-6-calvinwan@google.com>

On Tue, May 2, 2023 at 2:15 PM Calvin Wan <calvinwan@google.com> wrote:

Show 21 quoted lines

>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> ---
>  strbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/strbuf.c b/strbuf.c
> index 178d75f250..d5978fee4e 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -3,7 +3,7 @@
>  #include "environment.h"
>  #include "gettext.h"
>  #include "hex.h"
> -#include "refs.h"
> +#include "strbuf.h"
>  #include "string-list.h"
>  #include "utf8.h"
>  #include "date.h"
> --
> 2.40.1.495.gc816e09b53d-goog

The commit message feels misleading. A little digging shows that refs.h was once upon a time needed, but no longer was as of 6bab74e7fb8 ("strbuf: move strbuf_branchname to sha1_name.c", 2010-11-06). So, you're removing an unnecessary include, but adding one back that was missing. I guess that might count as "clarifying", but maybe some of that extra context in the commit message would be useful?