Re: [PATCH v2 0/7] strbuf cleanups

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 7, 2023, 21:47 UTC
Message-ID: <64581c7d6d085_4e61294e0@chronos.notmuch>
In-Reply-To: <CABPp-BGk-s+4b+OHi9FDXjwz5BeZPS8qb4XiJ8CVwkt8Siaq8A@mail.gmail.com>

Elijah Newren wrote:

Show 7 quoted lines

> On Wed, May 3, 2023 at 11:48 AM Calvin Wan <calvinwan@google.com> wrote:
> >
> > Strbuf is a widely used basic structure that should only interact with
> > other primitives in strbuf.[ch].
> 
> "should"?  I agree with moving things in this direction, but the
> wording here suggests there's a pre-existing directive or guideline;

No, it doesn't.

"You should see a doctor about that cough" is not a directive, it's merely an advice.

> Maybe this should be reworded to "This series modifies strbuf to focus on
> string manipulation with minimal other dependencies"?

And ironoically you use the word "should" to provide your own advice on how to avoid using "should" as an advice.

I agree it would be ideal if strbuf interacted only with other primitives in strbuf.[ch], so I agree "should" is a perfectly fine word to describe such a normative statement.

-- 
Felipe Contreras