git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fix clone guess_dir_name regression in v2.4.8

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 5, 2015, 17:19 UTC
Message-ID
<xmqq8u9p4pqb.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150805083526.GA22325@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 16 quoted lines
> On Tue, Aug 04, 2015 at 06:42:46PM -0400, Jeff King wrote:
>
>> > I did not intend this change in behavior, and I can confirm that
>> > reverting my patch restores the original behavior. Thanks for bringing
>> > this to my attention, I'll work on a patch.
>> 
>> I think this regression is in v2.4.8, as well. We should be able to use
>> a running "len" instead of the "end" pointer in the earlier part, and
>> then use strip_suffix_mem later (to strip from our already-reduced
>> length, rather than the full NUL-terminated string). Like this:
>
> Looks like "git clone --bare host:foo/.git" is broken, too. I've added
> some tests to cover the recently broken cases, as well as some obvious
> normal cases (which the patch I sent earlier break!). And as a bonus, we
> can easily cover Patrick's root-repo problems (so people will actually
> run the tests, unlike the stuff in t1509. :) ).

Sorry, my fault; I should have been much less trusting while queuing a patch like that offending one that was meant to be a no-op.

Show 5 quoted lines
> Here are the patches.
>
>   [1/2]: clone: add tests for output directory
>   [2/2]: clone: use computed length in guess_dir_name
>
Thanks.
Previous: Sebastian SchuberthNext: Jeff King
Message 22 of 24 in “clone: Make use of the strip_suffix() helper method”
  1. clone: Make use of the strip_suffix() helper methodSebastian Schuberth, Jul 9, 2015
  2. Jeff KingJul 9, 2015
  3. Sebastian SchuberthJul 9, 2015
  4. clone: Simplify string handling in guess_dir_name()Sebastian Schuberth, Jul 9, 2015
  5. Junio C HamanoJul 9, 2015
  6. Sebastian SchuberthJul 9, 2015
  7. clone: Simplify string handling in guess_dir_name()Sebastian Schuberth, Jul 9, 2015
  8. clone: simplify string handling in guess_dir_name()Sebastian Schuberth, Jul 9, 2015
  9. Junio C HamanoJul 9, 2015
  10. Sebastian SchuberthJul 9, 2015
  11. Lukas FleischerAug 4, 2015
  12. Sebastian SchuberthAug 4, 2015
  13. Jeff KingAug 4, 2015
  14. Patrick SteinhardtAug 5, 2015
  15. Jeff KingAug 5, 2015
  16. Patrick SteinhardtAug 5, 2015
  17. Jeff KingAug 5, 2015
  18. 0/2 fix clone guess_dir_name regression in v2.4.8Jeff King, Aug 5, 2015
  19. 1/2 clone: add tests for output directoryJeff King, Aug 5, 2015
  20. 2/2 clone: use computed length in guess_dir_nameJeff King, Aug 5, 2015
  21. Sebastian SchuberthAug 5, 2015
  22. Junio C HamanoAug 5, 2015
  23. Jeff KingAug 5, 2015
  24. Junio C HamanoJul 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.