Re: [PATCH v4] clone: simplify string handling in guess_dir_name()

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 5, 2015, 09:06 UTC
Message-ID: <20150805090603.GC1103@pks-pc.localdomain>
In-Reply-To: <20150805084147.GC28212@sigill.intra.peff.net>

On Wed, Aug 05, 2015 at 04:41:48AM -0400, Jeff King wrote:

Show 17 quoted lines

> On Wed, Aug 05, 2015 at 08:08:52AM +0200, Patrick Steinhardt wrote:
> 
> > > Sadly we cannot just `strip_suffix_mem(repo, &len, "/.git"))` in the
> > > earlier code, as we have to account for multiple directory separators. I
> > > believe the above code does the right thing, though. I haven't looked at
> > > how badly it interacts with the other guess_dir_name work from Patrick
> > > Steinhardt that has been going on, though.
> > 
> > It shouldn't be hard rebasing my work onto this. If it's being
> > applied I'll come up with a new version.
> 
> Thanks, it is always nice when contributors are flexible and easy to
> work with. :)
> 
> Hopefully the new tests I've added can help you out, as well.
> 
> -Peff

You're welcome. And yes, your tests help me quite a lot here. Got tedious to always set up the chroot. Guess I'll still send my fixes for the chroot-tests as a separate patch series, even though I don't require them anymore.

Short question on how to proceed: should I mention that my patch series builds upon your patches or just include them in my series?

Patrick