Re: [PATCH v4] clone: simplify string handling in guess_dir_name()

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Jul 9, 2015, 21:23 UTC
Message-ID: <CAHGBnuO+Anxc_ftxTMFiYXoxu+9tfiR-zaRSzjTTA7PUwzTWKQ@mail.gmail.com>
In-Reply-To: <xmqqfv4xuiwh.fsf@gitster.dls.corp.google.com>

On Thu, Jul 9, 2015 at 11:21 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

>> -     if (is_bare) {
>> -             struct strbuf result = STRBUF_INIT;
>> -             strbuf_addf(&result, "%.*s.git", (int)(end - start), start);
>> -             dir = strbuf_detach(&result, NULL);
>> -     } else
>> +     if (is_bare)
>> +             dir = xstrfmt("%.*s.git", (int)len, start);
>> +     else
>>               dir = xstrndup(start, end - start);
>
> The last one needs to be adjusted with s/end - start/len/.  The
> last-minute rewrite without testing shows; your first two patches
> correctly used "len" ;-)

Doh, you're right, sorry for that.

> No need to resend.  Will locally tweak before queuing.

Thanks!

-- 
Sebastian Schuberth