From: Junio C Hamano Date: Wed, 05 Aug 2015 17:19:56 GMT Subject: Re: [PATCH 0/2] fix clone guess_dir_name regression in v2.4.8 Message-ID: In-Reply-To: <20150805083526.GA22325@sigill.intra.peff.net> Jeff King writes: > On Tue, Aug 04, 2015 at 06:42:46PM -0400, Jeff King wrote: > >> > I did not intend this change in behavior, and I can confirm that >> > reverting my patch restores the original behavior. Thanks for bringing >> > this to my attention, I'll work on a patch. >> >> I think this regression is in v2.4.8, as well. We should be able to use >> a running "len" instead of the "end" pointer in the earlier part, and >> then use strip_suffix_mem later (to strip from our already-reduced >> length, rather than the full NUL-terminated string). Like this: > > Looks like "git clone --bare host:foo/.git" is broken, too. I've added > some tests to cover the recently broken cases, as well as some obvious > normal cases (which the patch I sent earlier break!). And as a bonus, we > can easily cover Patrick's root-repo problems (so people will actually > run the tests, unlike the stuff in t1509. :) ). Sorry, my fault; I should have been much less trusting while queuing a patch like that offending one that was meant to be a no-op. > Here are the patches. > > [1/2]: clone: add tests for output directory > [2/2]: clone: use computed length in guess_dir_name > Thanks.