Re: [PATCH v2 2/6] commit-graph: always parse before commit_graph_data_at()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 8, 2021, 05:55 UTC
Message-ID: <xmqq8s7z6r3c.fsf@gitster.c.googlers.com>
In-Reply-To: <74f1eeab-3211-71e5-c83c-19c0b7c0257d@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 6 quoted lines

> The reflog _might_ have something of value there, but the hope is
> that very few commits are actually being force-pushed away. The focus
> is to prioritize the deep history, and it would definitely be an
> anti-pattern if the commits in the reflog are so numerous that they
> must be tracked by the commit-graph. Of course, skipping the --reachable
> option enables a way to gather these commits as necessary.

Sure. As long as gaps in commit-graph coverage only affect performance and never correctness (e.g. even if the things that are only reachable from reflog entries are not covered by commit-graph, when 'git prune' wants to know if an object can safely pruned, we will correctly say "no, do not prune it yet"), that is perfectly fine.