Re: [PATCH v2 0/6] Generation Number v2: Fix a tricky split graph bug

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 2, 2021, 03:08 UTC
Message-ID: <YBjCHxaMCYyUZ2t5@nand.local>
In-Reply-To: <pull.850.v2.git.1612234883.gitgitgadget@gmail.com>

On Tue, Feb 02, 2021 at 03:01:17AM +0000, Derrick Stolee via GitGitGadget wrote:

Show 12 quoted lines

> Updates in v2
> =============
>
>  * Fixed some typos or other clarifications in commit messages.
>
>  * The loop assigning read_generation_data is skipped if they already all
>    agree with value 1.
>
>  * I split compute_generation_numbers into two methods. This essentially
>    splits the previous patch 4 into patches 4 & 5 here. The new patch 4 just
>    splits the logic as-is, then the new patch 5 does the re-initialization
>    of generation values when in the upgrade scenario.

Thanks for addressing my nits. I'm much happier with patch 5 as a result of your changes, so I think this series was a positive step forward not only for fixing a correctness bug, but also for improving the readability of commit-graph.c.

Both the range-diff and the new patches look good to me, so this series has my:

  Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks, Taylor