Re: [PATCH v2 2/6] commit-graph: always parse before commit_graph_data_at()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 3, 2021, 02:06 UTC
Message-ID: <xmqq7dnpewg4.fsf@gitster.c.googlers.com>
In-Reply-To: <1dab0bf0-9a7f-370a-c807-25d67ac7a0a0@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 5 quoted lines

>> - what is the recommended way to recover from this state?  "git fsck"
>>   shows the repositories to have no problems.  "git help commit-graph"
>>   doesn't show a command for users to use; is
>>   `rm -fr .git/objects/info/commit-graphs/` the recommended recovery
>>   command?

"rm -f .git/objects/info/commit-graph" as well, no?

> That, followed by `git commit-graph write --reachable [--changed-paths]`
> depending on what they want.

Just out of curiosity, how important is "--reachable"? It only traverses from the tips of refs and unlike fsck and repack, not from reflog entries (or the index for that matter, but that shouldn't make much difference as there is no _commit_ in the index).

Show 6 quoted lines

>> - is there configuration or a patch we can roll out to help affected
>>   users recover from this state?
>
> If you are willing, then take v2 of this series and follow through by
> clearing the commit-graph files of affected users. Note that you can
> be proactive using `git commit-graph verify` to see who needs rewrites.

FYI, today's 368b6599 (Merge branch 'ds/commit-graph-genno-fix' into jch, 2021-02-01) has this stuff.