git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 10, 2023, 22:01 UTC
Message-ID
<xmqq8rh5gox7.fsf@gitster.g>
In-Reply-To
<20230210171338.81906-1-vinayakdev.sci@gmail.com>
Vinayak Dev <vinayakdev.sci@gmail.com> writes:
> Revert changes to alias.c, and change variable types in apply.c

When you send out a rerolled series, you do not have to show your past mistakes. This [v2] is structured as a three patch series whose first one makes a similar mess as what [v1] did, the second one and the third one then revert some parts of that earlier mess.

That is not what you want to show your reviewers, and more importantly, that is not what we want to record in our history. Rerolling a series is your chance to pretend that you are much better programmer than you who wrote the [v1] patch. The review exchange is to help you do that. Please take advantage of that.

You may find "git rebase -i" is a useful tool to help you pretend that you got to the ideal end result without these "I tried this first, which was wrong in these points, which I correct in a subsequent step" steps.

Thanks.
Previous: Vinayak DevNext: Vinayak Dev
Message 5 of 8 in “{apply,alias}: convert pre-processor macros to enums”
  1. 0/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  2. 1/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  3. 2/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  4. 3/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  5. Junio C HamanoFeb 10, 2023
  6. Vinayak DevFeb 11, 2023
  7. Eric SunshineFeb 15, 2023
  8. Vinayak DevFeb 15, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.