Re: [PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums

From: Vinayak Dev <vinayakdev.sci@gmail.com>
Date: Feb 15, 2023, 08:19 UTC
Message-ID: <CADE8NaquOppesW5v9LMNE=TAu5J=bS9uCgkhkbu4QZ9JpoSLxg@mail.gmail.com>
In-Reply-To: <CAPig+cT98gscoD=Fh-QzJxruxdZmjGKW3gy95cA3xAokV7J4rw@mail.gmail.com>

On Wed, 15 Feb 2023 at 05:34, Eric Sunshine <sunshine@sunshineco.com> wrote:

>
> On Fri, Feb 10, 2023 at 11:00 PM Vinayak Dev <vinayakdev.sci@gmail.com> wrote:

Show 16 quoted lines

> > Should I re-send [v2] after making corrections for this mistake?
> > That would make the corrections more obvious and the mistakes less.
>
> You should send a v3 which completely replaces v1 and v2.
>
> To prepare v3, use the "squash" (or "fixup") command of `git rebase
> -i` to squash all three patches from v2 into a single patch, so that
> v3 consists of just one patch. The squashed patch should contain only
> changes to "apply.c"; specifically, changing #define to `enum`, and
> changing the variable declarations from `int` to `enum`.
>
> You can also update the commit message of the squashed patch so that
> it explains the reason for the patch: specifically, the debugger will
> display the values symbolically rather than as mere numbers.
>
> Finally, proofread the commit message and the patch itself, and resubmit as v3.

Ok! I have absolutely understood your points. I will roll out v3 with appropriate changes, as you suggest.

Thanks a lot!
 Vinayak