git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/3] {apply,alias}: convert pre-processor macros to enums

From
Vinayak Dev <vinayakdev.sci@gmail.com>
Date
Feb 10, 2023, 17:13 UTC
Message-ID
<20230210171338.81906-1-vinayakdev.sci@gmail.com>
Revert changes to alias.c, and change variable types in apply.c

It is needed to revert changes to alias.c as the changed #define macros were actually returned values, so it is not right to change their types to enums.

Also, SPLIT_CMDLINE_BAD_ENDING is returned after changing to negative sign, breaking the validity of the conversion to enum.

The changes to apply.c are actually useful only if the variable types are enum, so change the type of variable int patch_method and function argument int side to enums as well.

Changes are in accordance to Eric's review of v1: https://lore.kernel.org/git/CADE8NappDSaZrMLeqak4is59oL=X1wJOj2eCLLjaCKyrnoK9PQ@mail.gmail.com/T/

Vinayak Dev (2):
  Revert added enum to #define
  Change types of int patch_method and int side to enum
Vinayak Dev (1):
  Change #define to enum in apply.c and alias.c
 alias.c |  1 +
 apply.c | 17 +++++++++++------
 2 files changed, 12 insertions(+), 6 deletions(-)

Range-diff against v1: 1: f64b1af2a5 = 1: eaaa09dfb1 Change #define to enum in apply.c and alias.c -: ---------- > 2: 86e27e7f64 Revert added enum to #define -: ---------- > 3: 17233eb3fe Change types of int patch_method and int side to enum

-- 
2.39.1
Next: Vinayak Dev
Message 1 of 8 in “{apply,alias}: convert pre-processor macros to enums”
  1. 0/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  2. 1/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  3. 2/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  4. 3/3 {apply,alias}: convert pre-processor macros to enumsVinayak Dev, Feb 10, 2023
  5. Junio C HamanoFeb 10, 2023
  6. Vinayak DevFeb 11, 2023
  7. Eric SunshineFeb 15, 2023
  8. Vinayak DevFeb 15, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.