git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: make warning less passive aggressive

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 21, 2024, 17:31 UTC
Message-ID
<xmqq8r3dpvun.fsf@gitster.g>
In-Reply-To
<ZdWiyYhKAB3_P6_k@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 7 quoted lines
>>  	if (options.action != ACTION_NONE && !in_progress)
>> -		die(_("No rebase in progress?"));
>> +		die(_("No rebase in progress"));
>
> While we're at it changing this message, do we also want to convert it
> to start with a lower-case letter so that it aligns with our error
> message style?
Good eyes.  Thanks for a good suggestion.
Previous: Patrick SteinhardtNext: Harmen Stoppels via GitGitGadget
Message 14 of 18 in “rebase: make warning less passive aggressive”
  1. rebase: make warning less passive aggressiveHarmen Stoppels via GitGitGadget, Feb 20, 2024
  2. Junio C HamanoFeb 20, 2024
  3. Michal SuchánekFeb 21, 2024
  4. Junio C HamanoFeb 21, 2024
  5. Junio C HamanoFeb 21, 2024
  6. Michal SuchánekFeb 21, 2024
  7. Jean-Noël AVILAFeb 21, 2024
  8. Junio C HamanoFeb 21, 2024
  9. Junio C HamanoFeb 22, 2024
  10. Jean-Noël AVILAFeb 22, 2024
  11. Michal SuchánekFeb 22, 2024
  12. Junio C HamanoFeb 22, 2024
  13. Patrick SteinhardtFeb 21, 2024
  14. Junio C HamanoFeb 21, 2024
  15. rebase: make warning less passive aggressiveHarmen Stoppels via GitGitGadget, Feb 21, 2024
  16. Patrick SteinhardtFeb 22, 2024
  17. Kristoffer HaugsbakkFeb 22, 2024
  18. Junio C HamanoFeb 22, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.