Re: [PATCH] rebase: make warning less passive aggressive

From: Michal Suchánek <msuchanek@suse.de>
Date: Feb 22, 2024, 11:04 UTC
Message-ID: <20240222110416.GD9696@kitsune.suse.cz>
In-Reply-To: <7633780.EvYhyI6sBW@cayenne>

Hello,

On Thu, Feb 22, 2024 at 11:01:59AM +0100, Jean-Noël AVILA wrote:

Show 8 quoted lines

> On Wednesday, 21 February 2024 23:46:10 CET Junio C Hamano wrote:
> > Jean-Noël AVILA <jn.avila@free.fr> writes:
> > 
> > > As a translator, I'm less bothered by editing a sentence to remove a 
> question 
> > > mark (maybe enforcing a language style and reformulating the sentence by 
> the 
> > > way), than by translating again and again similar sentences.

Indeed, the style part is the key here.

The message that is changed here was quite stylistically poorly written which is why only removing the question mark is correct, and it's why it's changed in the first place, too.

While this is faithfully reflected in multiple language translations there is no saying that's the case for all languages, at least basic understanding of the grammar of the language in question is needed to verify that.

Show 10 quoted lines

> > But the above assumes that for your language, the ONLY thing to turn
> > such a rhetorical "passive aggressive" question into grammatically
> > correct statement of a fact is to remove the question mark.  It may
> > not be universally true for all languages, and for some language,
> > even after msgmerge did its job correctly, you may need to do more
> > than just removing the question mark to adjust the remaining "foo
> > bar" part.
> > 
> 
> I perfectly agree with you.

Indeed, and that's why per-language review for such change is needed.

Thanks

Michal