Re: [PATCH v2] rebase: make warning less passive aggressive

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Feb 22, 2024, 10:53 UTC
Message-ID: <759cbb30-96dd-456a-baab-b9451d400dcb@app.fastmail.com>
In-Reply-To: <pull.1669.v2.git.1708537097448.gitgitgadget@gmail.com>

On Wed, Feb 21, 2024, at 18:38, Harmen Stoppels via GitGitGadget wrote:

Show 9 quoted lines

> From: Harmen Stoppels <me@harmenstoppels.nl>
>
> When you run `git rebase --continue` when no rebase is in progress, git
> outputs `fatal: No rebase in progress?` which is not a question but a
> statement. Make it appear as a statement, and use lowercase to align
> with error message style.
>
> Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
> ---

I’ve interpreted this error as: I’m not quite sure but it looks like you are not in the middle of a rebase? Like it can’t be completely sure. Maybe from a more “primitive” time, implementation-wise?[1] :)

(I waited to make this reply in order to see what others would say. And apparently there is no need for a hedging/passive aggressive question mark.)

† 1: 031321c654d (Add --continue and --abort options to git-rebase.,
    2006-04-26)

-- 
Kristoffer Haugsbakk