Re: [PATCH] rebase: make warning less passive aggressive

From: Michal Suchánek <msuchanek@suse.de>
Date: Feb 21, 2024, 17:38 UTC
Message-ID: <20240221173822.GA9696@kitsune.suse.cz>
In-Reply-To: <xmqqv86jqc2e.fsf@gitster.g>

On Tue, Feb 20, 2024 at 09:29:13AM -0800, Junio C Hamano wrote:

Show 16 quoted lines

> "Harmen Stoppels via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > From: Harmen Stoppels <me@harmenstoppels.nl>
> >
> > When you run `git rebase --continue` when no rebase is in progress, git
> > outputs `fatal: no rebase in progress?` which is not a question but a
> > statement. This commit makes it appear as a statement.
> 
> "This commit makes it appear" -> "Make it appear" (see
> SubmittingPatches).
> 
> >  builtin/rebase.c | 2 +-
> 
> This change is very good, but a commit that touches code should not
> touch po/ localizations in this project.  They are updated to match
> the code change by respective language teams.

Or if it does touch the po files it could as well update the translations.

There are changes that can be trivially translated without any knowledge of the target language.

Thanks

Michal