Re: [PATCH 00/13] reftable: prepare for re-seekable iterators

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2024, 17:17 UTC
Message-ID: <xmqq8r0h60yc.fsf@gitster.g>
In-Reply-To: <Zj5HvF-Uq0uWranj@framework>

Patrick Steinhardt <ps@pks.im> writes:

> It's needed in the sense that your version leaks memory -- the `ti`
> pointer is never free'd. Other than that they are equivalent indeed.

Ah, OK, I somehow misread that _close() will free the resource, but it only frees the resources held by the shell and not the shell itself.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.