Re: [PATCH v2 03/13] reftable/reader: unify indexed and linear seeking

From: Patrick Steinhardt <ps@pks.im>
Date: May 22, 2024, 07:23 UTC
Message-ID: <Zk2de9lNrNJRuwUp@tanuki>
In-Reply-To: <CAOLa=ZSC4OF9b1STzEZfPjrJDbee04A-piNZ86kDS_GDij_3Jw@mail.gmail.com>

On Tue, May 21, 2024 at 02:41:27PM +0000, Karthik Nayak wrote:

Show 6 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > In `reader_seek_internal()` we either end up doing an indexed seek when
> > there is one or a linear seek otherwise. These two code paths are
> 
> Are we missing the subject here?

Hm. "one" refers back to "indexed" and is supposed to mean "index" here. I agree that this is easy to misread though and may not even be proper English.

It doesn't really feel worth it to rebase this series just for this issue, but if I did it would be 's/one/an index/'. Let me know in case you disagree though.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.