Re: [PATCH v2 03/13] reftable/reader: unify indexed and linear seeking
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- May 22, 2024, 07:56 UTC
- Message-ID
- <CAOLa=ZR=681m_XE=-CRrEZfQLPdbSAm7S8M0b7ZotUSG9LbX+Q@mail.gmail.com>
- In-Reply-To
- <Zk2de9lNrNJRuwUp@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 17 quoted lines
> On Tue, May 21, 2024 at 02:41:27PM +0000, Karthik Nayak wrote: >> Patrick Steinhardt <ps@pks.im> writes: >> >> > In `reader_seek_internal()` we either end up doing an indexed seek when >> > there is one or a linear seek otherwise. These two code paths are >> >> Are we missing the subject here? > > Hm. "one" refers back to "indexed" and is supposed to mean "index" here. > I agree that this is easy to misread though and may not even be proper > English. > > It doesn't really feel worth it to rebase this series just for this > issue, but if I did it would be 's/one/an index/'. Let me know in case > you disagree though. > > Patrick
Okay that makes a bunch of sense, I think it is okay though and not worth a reroll.
Karthik