Re: [PATCH v2 00/13] reftable: prepare for re-seekable iterators

From: Karthik Nayak <karthik.188@gmail.com>
Date: May 21, 2024, 15:31 UTC
Message-ID: <CAOLa=ZQPS_gVAf-f3cW_=C18B4C7i-gh=bYMWW2X03S4nYK3Aw@mail.gmail.com>
In-Reply-To: <cover.1715589670.git.ps@pks.im>

Hello,

Patrick Steinhardt <ps@pks.im> writes:

Show 22 quoted lines

> Hi,
>
> this is the second version of my patch series that prepares the reftable
> iterators to become re-seekable. These refactorings will eventually
> allow us to reuse data structures by iterators and optimize for certain
> cases.
>
> Changes compared to v1:
>
>   - Various fixes to commit messages.
>
>   - Fixed a copy & pasted comment to refer to logs instead of refs.
>
> The series continues to build on top of ps/reftable-write-optim. There
> is a merge conflict with the in-flight ps/reftable-write-options, but
> given that this series has not yet been merged to next and because Junio
> has already resolved the conflict in "seen" I decided to not pull it in
> as an additional dependency.
>
> Thanks!
>
> Patrick

I didn't review the earlier version. I did go through the patches in this version, I only have a nit in the first patch, not worth a reroll. Thanks for the series, I have nothing more to add.

Karthik