Re: [PATCH 1/2] Support for $FILENAMES in tool definitions
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 27, 2016, 17:53 UTC
- Message-ID
- <xmqq7fdabjsb.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <57716227.1030104@gmail.com>
Jakub Narębski <jnareb@gmail.com> writes:
Show 14 quoted lines
> On 2016-06-27, Alex Riesen wrote:
>
>> This adds a FILENAMES environment variable, which contains the repository
>> pathnames of all selected files the list.
>> The variable contains the names separated by spaces.
>
> Why not separate filenames with end-of-line character (LF)? It would still
> be broken for some filenames, but only for unportable ones. Filenames with
> internal space (common on MS Windows) would work then.
>
> http://www.dwheeler.com/essays/filenames-in-shell.html
>
> If Tcl allows it, you could separate filenames in FILENAMES environment
> variable with NUL ("\0") character...Tcl may or may not handle a string with an embedded NUL, but I think it is hard to have an embedded NUL in an environment variable.
Use of LF is a good suggestion regardless.