git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Support for $FILENAMES in tool definitions

From
Jakub Narębski <jnareb@gmail.com>
Date
Jun 27, 2016, 17:28 UTC
Message-ID
<57716227.1030104@gmail.com>
In-Reply-To
<20160627132137.GC4194@pflmari>
On 2016-06-27, Alex Riesen wrote:
> This adds a FILENAMES environment variable, which contains the repository
> pathnames of all selected files the list.
> The variable contains the names separated by spaces.

Why not separate filenames with end-of-line character (LF)? It would still be broken for some filenames, but only for unportable ones. Filenames with internal space (common on MS Windows) would work then.

  http://www.dwheeler.com/essays/filenames-in-shell.html
 
If Tcl allows it, you could separate filenames in FILENAMES environment
variable with NUL ("\0") character...
> Similar to the FILENAME it is broken yet, if the names contain spaces.

Could you clarify? Did you meant that FILENAMES environment variable is similar to existing FILENAME variable, but broken for filenames which contain spaces, or did you mean that both FILENAME (how?) and FILENAMES are broken for filenames with spaces in them?

> 
> Note that the file marked and diffed immediately after starting the GUI up,
> is not actually selected. One must click on it once to really select it.

I'm not that familiar with git-gui / gitk; what do you mean by this sentence? Could you summarize how FILENAME and FILENAMES work, please?

> 
> Signed-off-by: Alex Riesen <alexander.riesen@cetitec.com>
> ---
Previous: Alex RiesenNext: Junio C Hamano
Message 7 of 10 in “Support for $FILENAMES in tool definitions”
  1. 1/2 Support for $FILENAMES in tool definitionsAlex Riesen, Jun 27, 2016
  2. 2/2 Ensure the file in the diff pane is always in the list of selected filesAlex Riesen, Jun 27, 2016
  3. Jakub NarębskiJun 27, 2016
  4. Alex RiesenJun 28, 2016
  5. Johannes SchindelinJun 27, 2016
  6. Alex RiesenJun 28, 2016
  7. Jakub NarębskiJun 27, 2016
  8. Junio C HamanoJun 27, 2016
  9. Jakub NarębskiJun 27, 2016
  10. Alex RiesenJun 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.