Re: [PATCH 2/2] Ensure the file in the diff pane is always in the list of selected files
- From
Alex Riesen <alexander.riesen@cetitec.com>
- Date
- Jun 28, 2016, 08:03 UTC
- Message-ID
- <20160628080340.GA3710@pflmari>
- In-Reply-To
- <57716329.8000809@gmail.com>
Jakub Narębski, Mon, Jun 27, 2016 19:32:25 +0200:
Show 19 quoted lines
> W dniu 2016-06-27 o 15:23, Alex Riesen pisze: > > It is very confusing that the file, diff of which is displayed and which is > > marked as selected in the file list, is not, in fact, selected. I.e. the array > > of selected files does not contain an entry for it. > > > > Fixing this also improves the use of $FILENAMES in custom defined tools: one > > does not have to click the file in the list to make it selected. > > Could you improve the readability of the commit message, please? Perhaps > something like the following: > > It is very confusing that the file which diff is displayed is marked as > selected, but it is not in fact selected (that means the array of selected > files does not include the file in question). > > ... > > This patch lacks sign-off. >
Done. Also the prefix.
--- Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft. https://www.avast.com/antivirus