Re: [PATCH 1/2] Support for $FILENAMES in tool definitions

From: Jakub Narębski <jnareb@gmail.com>
Date: Jun 27, 2016, 18:09 UTC
Message-ID: <CANQwDwcq=O-ZVW2=+EnZnmCZpTjP=soQ_-cQP_n0p-TJ6DFQ-w@mail.gmail.com>
In-Reply-To: <xmqq7fdabjsb.fsf@gitster.mtv.corp.google.com>

On 27 June 2016 at 19:53, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Jakub Narębski <jnareb@gmail.com> writes:
>
>> On 2016-06-27, Alex Riesen wrote:
>>
>>> This adds a FILENAMES environment variable, which contains the repository
>>> pathnames of all selected files the list.
>>> The variable contains the names separated by spaces.
>>
>> Why not separate filenames with end-of-line character (LF)? It would still
>> be broken for some filenames, but only for unportable ones.  Filenames with
>> internal space (common on MS Windows) would work then.
>>
>>   http://www.dwheeler.com/essays/filenames-in-shell.html
>>
>> If Tcl allows it, you could separate filenames in FILENAMES environment
>> variable with NUL ("\0") character...
>
> Tcl may or may not handle a string with an embedded NUL, but I think
> it is hard to have an embedded NUL in an environment variable.
>
> Use of LF is a good suggestion regardless.

Or be a good citizen, and use $IFS... though then the user would need to set it to something sane-ish.

-- 
Jakub Narebski