Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2017, 14:54 UTC
Message-ID: <xmqq7ez1j0wv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <f00aeb42-75ad-d5ec-b4fb-c80b48827db4@free.fr>

Jean-Noël Avila <jn.avila@free.fr> writes:

Show 7 quoted lines

> Le 20/07/2017 à 20:57, Junio C Hamano a écrit :
>>
>> +	git diff --quiet HEAD && git diff --quiet --cached
>> +
>> +	@for s in $(LOCALIZED_C) $(LOCALIZED_SH) $(LOCALIZED_PERL); \
>
> Does PRIuMAX make sense for perl and sh files?

Not really; I did this primarily because I would prefer to keep things consistent, anticipating there may be some other things we need to replace before running gettext(1) for other reasons later.

I do not mind removing them, if Jiang/Dscho already reviewed and tested _this_ version (which we do not yet know), I'd prefer not to touch it for the upcoming release.

Thanks for reading it over.

Show 15 quoted lines

>> +	do \
>> +		sed -e 's|PRItime|PRIuMAX|g' <"$$s" >"$$s+" && \
>> +		cat "$$s+" >"$$s" && rm "$$s+"; \
>> +	done
>> +
>>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ $(XGETTEXT_FLAGS_C) $(LOCALIZED_C)
>>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing $(XGETTEXT_FLAGS_SH) \
>>  		$(LOCALIZED_SH)
>>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing $(XGETTEXT_FLAGS_PERL) \
>>  		$(LOCALIZED_PERL)
>> +
>> +	git reset --hard
>>  	mv $@+ $@
>>  
>>  .PHONY: pot