Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

From: Jean-Noël Avila <jn.avila@free.fr>
Date: Jul 21, 2017, 14:38 UTC
Message-ID: <f00aeb42-75ad-d5ec-b4fb-c80b48827db4@free.fr>
In-Reply-To: <xmqqfudrkkci.fsf@gitster.mtv.corp.google.com>

Le 20/07/2017 à 20:57, Junio C Hamano a écrit :

>
> +	git diff --quiet HEAD && git diff --quiet --cached
> +
> +	@for s in $(LOCALIZED_C) $(LOCALIZED_SH) $(LOCALIZED_PERL); \

Does PRIuMAX make sense for perl and sh files?

Show 15 quoted lines

> +	do \
> +		sed -e 's|PRItime|PRIuMAX|g' <"$$s" >"$$s+" && \
> +		cat "$$s+" >"$$s" && rm "$$s+"; \
> +	done
> +
>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ $(XGETTEXT_FLAGS_C) $(LOCALIZED_C)
>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing $(XGETTEXT_FLAGS_SH) \
>  		$(LOCALIZED_SH)
>  	$(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing $(XGETTEXT_FLAGS_PERL) \
>  		$(LOCALIZED_PERL)
> +
> +	git reset --hard
>  	mv $@+ $@
>  
>  .PHONY: pot