Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 22, 2017, 11:28 UTC
Message-ID: <alpine.DEB.2.21.1.1707221323420.4271@virtualbox>
In-Reply-To: <CANYiYbGkuGNNYn4OF5w=1+Pqn9hEHWcD+DYVB6AXRs0vFEsY2Q@mail.gmail.com>

Hi,

On Sat, 22 Jul 2017, Jiang Xin wrote:

> 2017-07-22 7:34 GMT+08:00 Junio C Hamano <gitster@pobox.com>:
> > Jiang Xin <worldhello.net@gmail.com> writes:
> >
> >> A very small hack on gettext.

I am 100% opposed to this hack. It is already cumbersome enough to find out what is involved in i18n (it took *me* five minutes to find out that much of the information is in po/README, with a lot of information stored *on an external site*, and I still managed to miss the `make pot` target).

If at all, we need to make things easier instead of harder.

Requiring potential volunteers to waste their time to compile an unnecessary fork of gettext? Not so great an idea.

Plus, each and every Git build would now have to compile their own gettext, too, as the vanilla one would not handle the .po files containing %<PRItime>!!!

And that requirement would impact instantaneously people like me, and even worse: some other packagers might be unaware of the new requirement which would not be caught during the build, and neither by the test suite. Double bad idea.

So let's go with Junio's patch.

Ciao, Dscho