Re: non-smooth progress indication for git fsck and git gc
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 4, 2018, 15:53 UTC
- Message-ID
- <xmqq7ek1cl87.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180902075528.GC18787@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> That code isn't lib-ified enough to be run in process, but I think the > patch below should give similar behavior to what fsck currently does. > We'd need to tell index-pack to use our fsck.* config for its checks, I > imagine. The progress here is still per-pack, but I think we could pass > in sufficient information to have it do one continuous meter across all > of the packs (see the in-code comment). > > And it makes the result multi-threaded, and lets us drop a bunch of > duplicate code. > > --- > builtin/fsck.c | 53 +++++++------ > pack-check.c | 142 ----------------------------------- > pack.h | 1 - > 3 files changed, 32 insertions(+), 164 deletions(-)
The numbers here are nice, even to readers who do not necessarily care about the progress meter output ;-)