Re: Antw: Re: non-smooth progress indication for git fsck and git gc

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 21, 2018, 15:21 UTC
Message-ID: <CACsJy8CztYM4XqC1uZ+MxXaQjp8qWjNYyNM1=wD0Q=PyqAmfVg@mail.gmail.com>
In-Reply-To: <20180821010712.GA32126@sigill.intra.peff.net>

On Tue, Aug 21, 2018 at 3:13 AM Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

> I _think_ they should work together OK without further modification.
> Once upon a time the caller had to say "don't show if we're past N%
> after M seconds", but I think with the current code we'd just show it if
> we're not completely finished after 2 seconds.
>
> So it really should just be a simple:
>
>   progress = start_delayed_progress("Hashing packfile", 0);
>
> That said, counting bytes would probably be ugly (just because the
> numbers get really big). We'd probably prefer to show a throughput or
> something.

Or just an ascii throbber. I think the important thing is communicate "I'm still doing something, not hanging up". "Hashing packfile" satisfies the "something" part, the throbber the "hanging".

-- 
Duy