Re: Antw: Re: non-smooth progress indication for git fsck and git gc
- From
- Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>
- Date
- Aug 21, 2018, 06:20 UTC
- Message-ID
- <5B7BAF25020000A10002CE20@gwsmtp1.uni-regensburg.de>
- In-Reply-To
- <20180821010712.GA32126@sigill.intra.peff.net>
>>> Jeff King <peff@peff.net> schrieb am 21.08.2018 um 03:07 in Nachricht
<20180821010712.GA32126@sigill.intra.peff.net>:
> On Mon, Aug 20, 2018 at 10:57:13AM +0200, Ævar Arnfjörð Bjarmason wrote: >
[...]
Show 6 quoted lines
> So it really should just be a simple:
>
> progress = start_delayed_progress("Hashing packfile", 0);
>
> That said, counting bytes would probably be ugly (just because the
> numbers get really big). We'd probably prefer to show a throughput orHi!
With big numbers you could apply scaling (the usual ISO suffixes), but after having read GBs, there wouldn't be much change visible unless you add significant fractional digits. So scaling seems good for absolute numbers, but not for growing numbers. Of course one could recursively scale the fractional parts again, but then the result will be lengthy again, then.
Regards, Ulrich
Show 8 quoted lines
> something. And as you noted, there's some refactoring to be done with > pack-check for it to show multiple progress meters. > > (I still think in the long run we would want to scrap that code, but > that's a much bigger job; I'm fine if somebody wants to do incremental > improvements in the meantime). > > -Peff