From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 21 Sep 2018 17:05:22 GMT
Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
Message-ID: <xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <f6663e27-cfe6-c927-746c-dfbeed5bb3a2@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>  (hdr-check)) didn't make it onto 'pu' - was there something else I
> needed to do? (I am still in two minds about sending an RFC patch
> on-top of patch #9).

I refrained from queuing it as I did not sense a clear resolution of
the discussion.

I found it a sign that you may want to update the log message to
explain "instead of adding a few forward decls, include the whole
commit.h because..." that you had to explain why the patch did what
it did to Derrick in a follow-up message.