Re: [PATCH] bugreport: add tool to generate debugging info
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 15, 2019, 22:29 UTC
- Message-ID
- <xmqq7e7e2hbv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190815215225.GB208753@google.com>
Emily Shaffer <emilyshaffer@google.com> writes:
Show 8 quoted lines
>> > +NOTE >> > +---- >> > +Bug reports can be sent to git@vger.kernel.org. >> >> I am not sure if this belongs here. > > Sure, I wasn't certain either. Would you rather I remove the "what to do > with this bugreport" NOTE section entirely?
Not really. You are invoking an editor to let the user edit the pre-populated report, and I would imagine that a comment in that file would be the best place to give instructions, not a manpage for "git bugreport" command.
Show 5 quoted lines
> So, what's your suggestion? Not to check the output at all? (This may > actually be fine; it occurred to me while reading your review that if a > user is filing a bug report about something, one of the diagnostic > commands in bugreport might be what's broken for them. So perhaps it > should be tolerant to missing information...)
Right.